Sending Patches VLC - Revision history

Fkuehne at 13:53, 8 March 2026

2026-03-08T13:53:24Z

← Older revision		Revision as of 13:53, 8 March 2026
Line 2:		Line 2:

	*Get a modern [[Git]] version, 1.7 or higher.		*Get a modern [[Git]] version, 1.7 or higher.
	*Make your changes and commit them.		*Make your changes and commit them on a branch.
	*Check your commit.		*Check your commit.
	*Produce a [[patch]] according to [[Git#Submitting_patches\|the Git page]], but '''don't send it yet'''. Read the following before sending.

	== Writing an appropriate description ==		== Writing an appropriate description ==

	*The patch email's subject '''should''' be prefixed by "'''[PATCH]'''".
	*You '''should''' include a description that will be the commit log message of your patch.		*You '''should''' include a description that will be the commit log message of your patch.
	*A more '''exhaustive explanation''' is also welcomed along with your patch. This could be the '''second paragraph''' of your commit log.		*A more '''exhaustive explanation''' is also welcomed along with your patch. This could be the '''second paragraph''' of your commit log.
Line 38:		Line 36:
	* Read your patch one more time using '''''git show''''', and check that it looks OK.		* Read your patch one more time using '''''git show''''', and check that it looks OK.

	== Sending it to ~~the vlc-devel list~~ ==		== Sending it to gitlab ==

	'''Now''' you can send ~~it to the~~ [~~http~~://~~mailman~~.videolan.org~~/listinfo~~/vlc~~-devel vlc-devel~~] ~~mailing list.~~		'''Now''' you can send a merge request against vlc.git on [https://code.videolan.org/vlc gitlab].

	~~''Please'' subscribe to it before sending your patch; otherwise, it may not get through the list's spam filters. You will be able to unsubscribe later easily if needed.~~

	~~''Try'' to avoid sending patches bigger than 100kB on the mailing list, if you can~~.

	== Following your patch ==		== Following your patch ==

	You ~~can check if~~ your ~~patch was received~~ by the ~~list at the [http://mailman~~.~~videolan.org/pipermail/vlc-devel/ list archive].~~		You will receive feedback on your merge request by core members of the VideoLAN team within a few days. It will move to the Accepted stage automatically. Rebasing your merge request will delay merging your work and consumes CI resources for nothing. We will do it for you once your work is accepted.

	~~If the patch gets approved, then there~~ will ~~normally be a post~~ to the ~~vlc-devel list to say "patch applied"~~. ~~There~~ will ~~also be a post to the [http://mailman~~.~~videolan.org/pipermail/vlc-commits/ vlc-commits] list ([http://mailman.videolan.org/listinfo/vlc-commits subscribe here])~~.

	== Getting your patch merged ==		== Getting your patch merged ==
Line 56:		Line 48:
	* ''Don't hesitate'' to '''re-ask''' for review if after a week there are no replies or comments.		* ''Don't hesitate'' to '''re-ask''' for review if after a week there are no replies or comments.
	* If there are comments, '''please answer''' to those and eventually correct your patch if possible.		* If there are comments, '''please answer''' to those and eventually correct your patch if possible.
	* ~~Check regularly on~~ the ~~[http://patches.videolan.org/project/vlc-devel/list/ patches website].~~		* Do not personally ping individuals of the VideoLAN community
	~~That should ensure that your patch gets merged.~~

	[[Category:Coding]]		[[Category:Coding]]
	[[Category:Security]]		[[Category:Security]]

DoesItReallyMatter: Add wikilink to patch

2019-02-15T20:05:23Z

Add wikilink to patch

← Older revision		Revision as of 20:05, 15 February 2019
Line 4:		Line 4:
	*Make your changes and commit them.		*Make your changes and commit them.
	*Check your commit.		*Check your commit.
	*Produce a patch according to [[Git#Submitting_patches\|the Git page]], but '''don't send it yet'''. Read the following before sending.		*Produce a [[patch]] according to [[Git#Submitting_patches\|the Git page]], but '''don't send it yet'''. Read the following before sending.

	== Writing an appropriate description ==		== Writing an appropriate description ==

DoesItReallyMatter: +:Category:Security

2019-02-15T00:55:04Z

+Category:Security

← Older revision		Revision as of 00:55, 15 February 2019
Line 60:		Line 60:

	[[Category:Coding]]		[[Category:Coding]]
			[[Category:Security]]

Courmisch: distcheck

2017-08-06T18:06:01Z

distcheck

← Older revision		Revision as of 18:06, 6 August 2017
Line 27:		Line 27:
	* The compiler does not mention new compilation '''warnings'''.		* The compiler does not mention new compilation '''warnings'''.
	** In some rare cases, warnings are unavoidable or counter-productive to fix. If so, explain it in the patch description.		** In some rare cases, warnings are unavoidable or counter-productive to fix. If so, explain it in the patch description.
			* If the patch adds, removes or moves one or more files, make sure the distribution still works, i.e. '''`make distcheck'''` runs succesfully to the end.
	* No '''trailing spaces''' are introduced (''git show --color'' show them in red).		* No '''trailing spaces''' are introduced (''git show --color'' show them in red).
	* Indentation is correct, no '''tabs''' are introduced.		* Indentation is correct, no '''tabs''' are introduced.

Fkuehne: /* How to produce a patch for VLC */ fix link

2015-12-14T15:48:23Z

How to produce a patch for VLC: fix link

← Older revision		Revision as of 15:48, 14 December 2015
Line 4:		Line 4:
	*Make your changes and commit them.		*Make your changes and commit them.
	*Check your commit.		*Check your commit.
	*Produce a patch according to [[Git#~~Submitting_patches_to_the_vlc-devel_or_x264-devel~~\|the Git page]], but '''don't send it yet'''. Read the following before sending.		*Produce a patch according to [[Git#Submitting_patches\|the Git page]], but '''don't send it yet'''. Read the following before sending.

	== Writing an appropriate description ==		== Writing an appropriate description ==

Courmisch: /* Check List */

2015-10-28T14:51:06Z

Check List

← Older revision		Revision as of 14:51, 28 October 2015
Line 16:		Line 16:
	When you send a patch make sure that:		When you send a patch make sure that:

	*It mostly '''complies''' with the [[Code Conventions]].		* The code mostly '''complies''' with the [[Code Conventions]].
	*~~It has~~ a ~~proper~~ license ~~for modifications~~.		* The patch applies to the latest '''master branch'''.
	*~~Make sure that it does~~ not ~~add more failure to~~ '''`make check`'''.		** Do not submit patches against a bugfix branch, except to backport fixes already found on the master branch.
	*~~Make sure that your patch is produced against the latest~~ '''~~master branch~~''' ~~and not 2.0-bugfix or 2.1-bugfix~~.		** Do not submit patches against releases. That would be completely useless.
	**~~Most of the time patches~~ are ~~against branch versions such as the 2.1.x series which is not a development version~~. If ~~this is a bugfix, it may be backported to 2.1-bugfix~~, ~~but~~ it ~~probably should go~~ in ~~master branch first. Translations are one exception to this rule~~.		** As a special exception, language translations go to the last bugfix branch directly.
	*~~Make sure your patch doesn't introduce~~ '''trailing spaces''' (''git show --color'' show them in red).		* Proper copyright license exists, and is stated where appropraite.
	*~~Make sure your patch doesn't introduce~~ '''tabs''' (tabs are ~~OK in~~ Makefiles ~~though)~~.		* The changes do not break the build.
	*~~Make sure~~ '''~~your~~ name is correctly set'''. That is, that you are using your fullname, which is correctly capitalized and so on.		** Testing all combinations is impossible. But you should at least test one.
	**For example, if you are '''John Smith''' with an e-mail of '''johnsmith@acme.example''', you should set your "Git name" to '''John Smith <johnsmith@acme.example>''' - real full name - not "jsmith", "John S", "J. Smith", "johnnykool1234", "J.S." or any other permutation.		* The tests suite still '''passes''' (i.e. '''`make check`''' runs without errors).
	*Read your patch one more time using '''''git show''''', and check that it looks OK.		* The compiler does not mention new compilation '''warnings'''.
			** In some rare cases, warnings are unavoidable or counter-productive to fix. If so, explain it in the patch description.
			* No '''trailing spaces''' are introduced (''git show --color'' show them in red).
			* Indentation is correct, no '''tabs''' are introduced.
			* No unrelated changes are included in the patch.
			** Especially changes to <code>.po</code> or <code>.pot</code> files do not belong within source code patches.
			** As a necessary exception, tabs are allowed within Makefiles.
			* '''Your name is correctly set'''. That is, that you are using your fullname, which is correctly capitalized and so on.
			** For example, if you are '''John Smith''' with an e-mail of '''johnsmith@acme.example''', you should set your "Git name" to '''John Smith <johnsmith@acme.example>''' - real full name - not "jsmith", "John S", "J. Smith", "johnnykool1234", "J.S." or any other permutation.
			* The patch description makes sense.
			* Read your patch one more time using '''''git show''''', and check that it looks OK.

	== Sending it to the vlc-devel list ==		== Sending it to the vlc-devel list ==

Courmisch: /* Check List */

2015-10-28T14:39:49Z

Check List

← Older revision		Revision as of 14:39, 28 October 2015
Line 16:		Line 16:
	When you send a patch make sure that:		When you send a patch make sure that:

	*It mostly '''complies''' to the [[Code Conventions]].		*It mostly '''complies''' with the [[Code Conventions]].
	*It has a proper license for modifications.		*It has a proper license for modifications.
	*Make sure that it does not add more failure to '''`make check`'''.		*Make sure that it does not add more failure to '''`make check`'''.

Ingve: Fix phrasing

2015-02-27T18:01:12Z

Fix phrasing

← Older revision		Revision as of 18:01, 27 February 2015
Line 1:		Line 1:
	== How to produce a patch for VLC ==		== How to produce a patch for VLC ==

	*Get a modern [[Git]] version, ~~like over~~ 1.7.		*Get a modern [[Git]] version, 1.7 or higher.
	*Make your changes and commit them.		*Make your changes and commit them.
	*Check your commit.		*Check your commit.

Edwardw: /* Sending it to the vlc-devel */

2014-06-29T02:48:56Z

Sending it to the vlc-devel

← Older revision		Revision as of 02:48, 29 June 2014
Line 27:		Line 27:
	*Read your patch one more time using '''''git show''''', and check that it looks OK.		*Read your patch one more time using '''''git show''''', and check that it looks OK.

	== Sending it to the vlc-devel ==		== Sending it to the vlc-devel list ==

	'''Now''' you can send it to the [http://mailman.videolan.org/listinfo/vlc-devel vlc-devel].		'''Now''' you can send it to the [http://mailman.videolan.org/listinfo/vlc-devel vlc-devel] mailing list.

	''Please'' subscribe to it before sending your patch, ~~or else~~ it may not ~~got~~ through the list's spam filters. You will be able to unsubscribe later easily if needed.		''Please'' subscribe to it before sending your patch; otherwise, it may not get through the list's spam filters. You will be able to unsubscribe later easily if needed.

	''Try'' to avoid sending patches bigger than 100kB on the mailing list, if you can.		''Try'' to avoid sending patches bigger than 100kB on the mailing list, if you can.

	== Following your patch ==		== Following your patch ==

J-b at 15:13, 1 October 2013

2013-10-01T15:13:17Z

← Older revision		Revision as of 15:13, 1 October 2013
Line 47:		Line 47:
	* Check regularly on the [http://patches.videolan.org/project/vlc-devel/list/ patches website].		* Check regularly on the [http://patches.videolan.org/project/vlc-devel/list/ patches website].
	That should ensure that your patch gets merged.		That should ensure that your patch gets merged.

			[[Category:Coding]]